----- Original Message ----- | Hi, | | This isn't quite right. | | error = gfs2_meta_inode_buffer(ip, &dibh); | if (error) | goto out; | ... | out: | brelse(dibh); | | If this returns an error, we'll do double brelse in out. | If gfs2_meta_inode_buffer returns an error, it has released the | buffer_head already. | | Regards, | | Bob Peterson | Red Hat File Systems
Never mind. It's not a double-brelse because dibh will still be NULL, and brelse(NULL) is a no-op. Bob Peterson
