On Thu, Nov 15, 2018 at 04:52:56PM +0800, Ming Lei wrote: > There are still cases in which we need to use bio_bvecs() for get the > number of multi-page segment, so introduce it. > > Cc: Dave Chinner <[email protected]> > Cc: Kent Overstreet <[email protected]> > Cc: Mike Snitzer <[email protected]> > Cc: [email protected] > Cc: Alexander Viro <[email protected]> > Cc: [email protected] > Cc: Shaohua Li <[email protected]> > Cc: [email protected] > Cc: [email protected] > Cc: David Sterba <[email protected]> > Cc: [email protected] > Cc: Darrick J. Wong <[email protected]> > Cc: [email protected] > Cc: Gao Xiang <[email protected]> > Cc: Christoph Hellwig <[email protected]> > Cc: Theodore Ts'o <[email protected]> > Cc: [email protected] > Cc: Coly Li <[email protected]> > Cc: [email protected] > Cc: Boaz Harrosh <[email protected]> > Cc: Bob Peterson <[email protected]> > Cc: [email protected]
Reviewed-by: Omar Sandoval <[email protected]> > Signed-off-by: Ming Lei <[email protected]> > --- > include/linux/bio.h | 30 +++++++++++++++++++++++++----- > 1 file changed, 25 insertions(+), 5 deletions(-) > > diff --git a/include/linux/bio.h b/include/linux/bio.h > index 1f0dcf109841..3496c816946e 100644 > --- a/include/linux/bio.h > +++ b/include/linux/bio.h > @@ -196,7 +196,6 @@ static inline unsigned bio_segments(struct bio *bio) > * We special case discard/write same/write zeroes, because they > * interpret bi_size differently: > */ > - > switch (bio_op(bio)) { > case REQ_OP_DISCARD: > case REQ_OP_SECURE_ERASE: > @@ -205,13 +204,34 @@ static inline unsigned bio_segments(struct bio *bio) > case REQ_OP_WRITE_SAME: > return 1; > default: > - break; > + bio_for_each_segment(bv, bio, iter) > + segs++; > + return segs; > } > +} > > - bio_for_each_segment(bv, bio, iter) > - segs++; > +static inline unsigned bio_bvecs(struct bio *bio) > +{ > + unsigned bvecs = 0; > + struct bio_vec bv; > + struct bvec_iter iter; > > - return segs; > + /* > + * We special case discard/write same/write zeroes, because they > + * interpret bi_size differently: > + */ > + switch (bio_op(bio)) { > + case REQ_OP_DISCARD: > + case REQ_OP_SECURE_ERASE: > + case REQ_OP_WRITE_ZEROES: > + return 0; > + case REQ_OP_WRITE_SAME: > + return 1; > + default: > + bio_for_each_bvec(bv, bio, iter) > + bvecs++; > + return bvecs; > + } > } > > /* > -- > 2.9.5 >
