On Mon, Nov 26, 2018 at 10:17:06AM +0800, Ming Lei wrote:
> We will support multi-page bvec soon, and have to deal with
> single-page vs multi-page bvec. This patch follows Christoph's
> suggestion to rename all the following helpers:
> 
>       for_each_bvec
>       bvec_iter_bvec
>       bvec_iter_len
>       bvec_iter_page
>       bvec_iter_offset
> 
> into:
>       for_each_segment
>       segment_iter_bvec
>       segment_iter_len
>       segment_iter_page
>       segment_iter_offset
> 
> so that these helpers named with 'segment' only deal with single-page
> bvec, or called segment. We will introduce helpers named with 'bvec'
> for multi-page bvec.
> 
> bvec_iter_advance() isn't renamed becasue this helper is always operated
> on real bvec even though multi-page bvec is supported.
> 
> Suggested-by: Christoph Hellwig <h...@lst.de>
> Signed-off-by: Ming Lei <ming....@redhat.com>

Looks fine,

Reviewed-by: Christoph Hellwig <h...@lst.de>

Reply via email to