On Tue, Nov 27, 2018 at 12:19:48AM +0100, Andreas Gruenbacher wrote: > Pan, > > On Mon, 26 Nov 2018 at 09:44, Pan Bian <bianpan2...@163.com> wrote: > > > __gfs2_set_acl will not increase the reference count of acl if it fails. > > In this case, posix_acl_release are called twice, one after > > __gfs2_set_acl and one in the error handling block. This patch does not > > release acl when __gfs2_set_acl fails. > > > > thanks for the bug report and patch; I think this should be fixed more > clearly as in the patch I've posted earlier today.
I have seen the patch. It is really much clearer. Thank you! Pan > > Andreas