Hi, We've seen this in testing with 4.19.
Full trace is at the bottom. Looking at the code though it looks like it will assert if the value of change is equal to the number of blocks currently allocated to the inode. Is this expected or should the assert be using >= instead of > ? Thanks, Mark -------------- 2018-12-24 00:07:03 UTC] [ 3366.209273] kernel BUG at fs/gfs2/inode.h:64! [2018-12-24 00:07:03 UTC] [ 3366.209305] invalid opcode: 0000 [#1] SMP NOPTI [2018-12-24 00:07:03 UTC] [ 3366.209327] CPU: 10 PID: 30664 Comm: kworker/10:1 Tainted: G O 4.19.0+0 #1 [2018-12-24 00:07:03 UTC] [ 3366.209352] Hardware name: HP ProLiant BL420c Gen8, BIOS I30 11/03/2014 [2018-12-24 00:07:03 UTC] [ 3366.209397] Workqueue: delete_workqueue delete_work_func [gfs2] [2018-12-24 00:07:03 UTC] [ 3366.209437] RIP: e030:gfs2_add_inode_blocks.part.33+0x10/0x12 [gfs2] [2018-12-24 00:07:03 UTC] [ 3366.209460] Code: 00 89 c2 48 c7 c7 80 bc 4c c0 31 c0 e8 ec 44 c1 c0 e9 68 fc ff ff 0f 0b 0f 0b 48 8b 47 28 48 8b b8 08 04 00 00 e8 bf dd ff ff <0f> 0b 0f 0b 0f 0b 66 66 66 66 90 0f 0b 48 8b 47 28 48 8b b8 08 04 [2018-12-24 00:07:03 UTC] [ 3366.209512] RSP: e02b:ffffc9004a53fbf0 EFLAGS: 00010246 [2018-12-24 00:07:03 UTC] [ 3366.209532] RAX: 0000000000000043 RBX: ffff8881709a4000 RCX: 0000000000000000 [2018-12-24 00:07:03 UTC] [ 3366.209556] RDX: 0000000000000000 RSI: ffff88818d496428 RDI: ffff88818d496428 [2018-12-24 00:07:03 UTC] [ 3366.209581] RBP: ffffc9004a53fdb0 R08: 0000000000000000 R09: 0000000000000553 [2018-12-24 00:07:03 UTC] [ 3366.209605] R10: 0000000000000000 R11: ffffc9004a53f968 R12: ffff888156a303d8 [2018-12-24 00:07:03 UTC] [ 3366.209629] R13: 0000000000f47524 R14: ffff8881709a3ac0 R15: ffff888188d31110 [2018-12-24 00:07:03 UTC] [ 3366.209683] FS: 00007fa73976e700(0000) GS:ffff88818d480000(0000) knlGS:0000000000000000 [2018-12-24 00:07:03 UTC] [ 3366.209709] CS: e033 DS: 0000 ES: 0000 CR0: 0000000080050033 [2018-12-24 00:07:03 UTC] [ 3366.209730] CR2: 00007fca0def3000 CR3: 0000000187fee000 CR4: 0000000000042660 [2018-12-24 00:07:03 UTC] [ 3366.209802] Call Trace: [2018-12-24 00:07:03 UTC] [ 3366.209835] punch_hole+0xf4f/0x10d0 [gfs2] [2018-12-24 00:07:03 UTC] [ 3366.209866] ? __switch_to_asm+0x40/0x70 [2018-12-24 00:07:03 UTC] [ 3366.209907] ? __switch_to_asm+0x40/0x70 [2018-12-24 00:07:03 UTC] [ 3366.209924] ? __switch_to_asm+0x40/0x70 [2018-12-24 00:07:03 UTC] [ 3366.209949] ? punch_hole+0xb3e/0x10d0 [gfs2] [2018-12-24 00:07:03 UTC] [ 3366.209983] gfs2_evict_inode+0x57b/0x680 [gfs2] [2018-12-24 00:07:03 UTC] [ 3366.210036] ? __inode_wait_for_writeback+0x75/0xe0 [2018-12-24 00:07:03 UTC] [ 3366.210066] ? gfs2_evict_inode+0x1c7/0x680 [gfs2] [2018-12-24 00:07:03 UTC] [ 3366.210090] evict+0xc6/0x1a0 [2018-12-24 00:07:03 UTC] [ 3366.210151] delete_work_func+0x60/0x70 [gfs2] [2018-12-24 00:07:03 UTC] [ 3366.210177] process_one_work+0x165/0x370 [2018-12-24 00:07:03 UTC] [ 3366.210197] worker_thread+0x49/0x3e0 [2018-12-24 00:07:03 UTC] [ 3366.210216] kthread+0xf8/0x130 [2018-12-24 00:07:03 UTC] [ 3366.210235] ? rescuer_thread+0x310/0x310 [2018-12-24 00:07:03 UTC] [ 3366.210284] ? kthread_bind+0x10/0x10 [2018-12-24 00:07:04 UTC] [ 3366.210301] ret_from_fork+0x35/0x40 [2018-12-24 00:07:04 UTC] [ 3366.210319] Modules linked in: tun nfsv3 nfs_acl nfs lockd grace fscache gfs2 dlm iscsi_tcp libiscsi_tcp libiscsi scsi_transport_iscsi 8021q garp mrp stp llc openvswitch nsh nf_nat_ipv6 nf_nat_ipv4 nf_conncount nf_nat ipt_REJECT nf_reject_ipv4 xt_tcpudp xt_multiport xt_conntrack nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 libcrc32c iptable_filter dm_multipath sunrpc sb_edac intel_powerclamp crct10dif_pclmul crc32_pclmul ghash_clmulni_intel pcbc aesni_intel aes_x86_64 crypto_simd cryptd glue_helper dm_mod sg hpilo lpc_ich intel_rapl_perf psmouse ipmi_si ipmi_devintf ipmi_msghandler nls_utf8 isofs acpi_power_meter loop xen_wdt ip_tables x_tables sd_mod uhci_hcd serio_raw ehci_pci ehci_hcd hpsa igb(O) scsi_transport_sas scsi_dh_rdac scsi_dh_hp_sw scsi_dh_emc scsi_dh_alua scsi_mod ipv6 crc_ccitt [2018-12-24 00:07:04 UTC] [ 3366.210663] ---[ end trace d36fcbebd28b36e9 ]---