On Wed, Feb 27, 2019 at 07:03:59PM +0100, Andreas Gruenbacher wrote: > Hi Christoph, > > I've tried to get your feedback on the lockdep_assert_held in > iomap_dio_rw in January and didn't hear back from you. Could you > please have a look?
Well, I guess we can drop the assert. But I'd really like to retain a comment that we require the caller to have a lock - unlike what most filesystems do with the old generic direct I/O code, which leads to all kinds of issues.