Andrew Price <anpr...@redhat.com> wrote:

> sget() is still used instead of sget_fc() as there doesn't seem to be an
> obvious replacement for the bdev pointer propagation to the test/set
> functions (yet?)

Umm...  What about the fs_context struct?  Why can't that be used to propagate
the bdev pointer?  That's kind of what it's for...

        struct super_block *sget_fc(
                struct fs_context *fc,
                int (*test)(struct super_block *, struct fs_context *),
                int (*set)(struct super_block *, struct fs_context *))

It looks like you should be able to stash the bdev pointer in the gfs2_args
struct.

> +     fsparam_s32    ("commit",             Opt_commit),
> +     fsparam_s32    ("statfs_quantum",     Opt_statfs_quantum),
> +     fsparam_s32    ("statfs_percent",     Opt_statfs_percent),

Why s32?  Why not u32?

David

Reply via email to