Function gfs2_freeze had a case statement that simply checked the
error code, but the break statements just made the logic hard to
read. This patch simplifies the logic in favor of a simple if.

Signed-off-by: Bob Peterson <rpete...@redhat.com>
---
 fs/gfs2/super.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c
index 1582cb11866e..7ffeb4379222 100644
--- a/fs/gfs2/super.c
+++ b/fs/gfs2/super.c
@@ -1043,20 +1043,14 @@ static int gfs2_freeze(struct super_block *sb)
                if (!error)
                        break;
 
-               switch (error) {
-               case -EBUSY:
+               if (error == -EBUSY)
                        fs_err(sdp, "waiting for recovery before freeze\n");
-                       break;
-
-               default:
+               else
                        fs_err(sdp, "error freezing FS: %d\n", error);
-                       break;
-               }
 
                fs_err(sdp, "retrying...\n");
                msleep(1000);
        }
-       error = 0;
 out:
        mutex_unlock(&sdp->sd_freeze_mutex);
        return error;
-- 
2.20.1

Reply via email to