Re: [Cluster-devel] [PATCH] fs: Move mark_inode_dirty out of __generic_write_end

[Christoph Hellwig]

At least for xfs we don't need the mark_inode_dirty at all.  Can you
solve your gfs2 requirements on top of something like the patch below?
Note that in general it seems like you should try to only update the
on-disk inode size in writeback completion anyway, otherwise you can
have a stale i_size update before the data was actually written.


diff --git a/fs/iomap.c b/fs/iomap.c
index c98107a6bf81..fcf2cbd39114 100644
--- a/fs/iomap.c
+++ b/fs/iomap.c
@@ -785,6 +785,7 @@ iomap_write_end(struct inode *inode, loff_t pos, unsigned 
len,
                unsigned copied, struct page *page, struct iomap *iomap)
 {
        const struct iomap_page_ops *page_ops = iomap->page_ops;
+       loff_t old_size = inode->i_size;
        int ret;
 
        if (iomap->type == IOMAP_INLINE) {
@@ -796,7 +797,12 @@ iomap_write_end(struct inode *inode, loff_t pos, unsigned 
len,
                ret = __iomap_write_end(inode, pos, len, copied, page, iomap);
        }
 
-       __generic_write_end(inode, pos, ret, page);
+       if (pos + ret > inode->i_size)
+               i_size_write(inode, pos + ret);
+       unlock_page(page);
+
+       if (old_size < pos)
+               pagecache_isize_extended(inode, old_size, pos);
        if (page_ops && page_ops->page_done)
                page_ops->page_done(inode, pos, copied, page, iomap);
        put_page(page);