On Thu, Nov 14, 2019 at 3:52 PM Bob Peterson <[email protected]> wrote:
> This patch adds function gfs2_withdrawn and replaces all checks
> for the SDF_WITHDRAWN bit to call it. This does not change the
> logic or function of gfs2, and it facilitates later improvements
> to the withdraw sequence.
This looks mostly okay, but:
> +/**
> + * gfs2_withdrawn - test whether the file system is withdrawing or withdrawn
> + * @sdp: the superblock
> + */
> +static inline bool gfs2_withdrawn(struct gfs2_sbd *sdp)
> +{
> + if (test_bit(SDF_WITHDRAWN, &sdp->sd_flags))
> + return true;
> + return false;
return test_bit(SDF_WITHDRAWN, &sdp->sd_flags)
> +}
Thanks,
Andreas
