Bob, On Fri, Apr 17, 2020 at 9:37 AM kbuild test robot <[email protected]> wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git > gfs2-iopen > head: c748e1ec9bd20d71265a148042f6bc97ffc5f343 > commit: c748e1ec9bd20d71265a148042f6bc97ffc5f343 [12/12] gfs2: Remove unused > function gfs2_glock_dq_wait > config: s390-defconfig (attached as .config) > compiler: s390-linux-gcc (GCC) 9.3.0 > reproduce: > wget > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O > ~/bin/make.cross > chmod +x ~/bin/make.cross > git checkout c748e1ec9bd20d71265a148042f6bc97ffc5f343 > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross > ARCH=s390 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kbuild test robot <[email protected]> > > All errors (new ones prefixed by >>): > > fs/gfs2/util.c: In function 'signal_our_withdraw': > >> fs/gfs2/util.c:126:3: error: implicit declaration of function > >> 'gfs2_glock_dq_wait'; did you mean 'gfs2_glock_nq_init'? > >> [-Werror=implicit-function-declaration] > 126 | gfs2_glock_dq_wait(&sdp->sd_journal_gh); > | ^~~~~~~~~~~~~~~~~~ > | gfs2_glock_nq_init > cc1: some warnings being treated as errors
commit "gfs2: Force withdraw to replay journals and wait for it to finish" adds three new users of gfs2_glock_dq_wait in function signal_our_withdraw. Is the waiting there done for a reason, or can we replace gfs2_glock_dq_wait with gfs2_glock_dq / gfs2_glock_dq_uninit in that function? Thanks, Andreas
