[Cluster-devel] [GFS2 PATCH 01/12] gfs2: rename gfs2_write_full_page to gfs2_write_jdata_page, remove parm

[Bob Peterson]

Since the function is only used for writing jdata pages, this patch
simply renames function gfs2_write_full_page to a more appropriate
name: gfs2_write_jdata_page. This makes the code easier to understand.

The function was only called in one place, which passed in a pointer to
function gfs2_get_block_noalloc. The function doesn't need to be
passed in. Therefore, this also eliminates the unnecessary parameter
to increase efficiency.

I also took the liberty of cleaning up the function comments.

Signed-off-by: Bob Peterson <rpete...@redhat.com>
---
 fs/gfs2/aops.c | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c
index 68cd700a2719..faf58c40485a 100644
--- a/fs/gfs2/aops.c
+++ b/fs/gfs2/aops.c
@@ -115,11 +115,16 @@ static int gfs2_writepage(struct page *page, struct 
writeback_control *wbc)
        return 0;
 }
 
-/* This is the same as calling block_write_full_page, but it also
+/**
+ * gfs2_write_jdata_page - gfs2 jdata-specific version of block_write_full_page
+ * @page: The page to write
+ * @wbc: The writeback control
+ *
+ * This is the same as calling block_write_full_page, but it also
  * writes pages outside of i_size
  */
-static int gfs2_write_full_page(struct page *page, get_block_t *get_block,
-                               struct writeback_control *wbc)
+static int gfs2_write_jdata_page(struct page *page,
+                                struct writeback_control *wbc)
 {
        struct inode * const inode = page->mapping->host;
        loff_t i_size = i_size_read(inode);
@@ -137,7 +142,7 @@ static int gfs2_write_full_page(struct page *page, 
get_block_t *get_block,
        if (page->index == end_index && offset)
                zero_user_segment(page, offset, PAGE_SIZE);
 
-       return __block_write_full_page(inode, page, get_block, wbc,
+       return __block_write_full_page(inode, page, gfs2_get_block_noalloc, wbc,
                                       end_buffer_async_write);
 }
 
@@ -166,7 +171,7 @@ static int __gfs2_jdata_writepage(struct page *page, struct 
writeback_control *w
                }
                gfs2_page_add_databufs(ip, page, 0, sdp->sd_vfs->s_blocksize);
        }
-       return gfs2_write_full_page(page, gfs2_get_block_noalloc, wbc);
+       return gfs2_write_jdata_page(page, wbc);
 }
 
 /**
-- 
2.26.2