Bob, Am Di., 5. Jan. 2021 um 14:28 Uhr schrieb Bob Peterson <[email protected]>: > ----- Original Message ----- > > From: Zhaoyang Huang <[email protected]> > > > > As gfs2_quotad_cachep and gfs2_glock_cachep have registered > > the shrinker, amending SLAB_RECLAIM_ACCOUNT when creating > > them, which make the slab acount to be presiced. > > > > Signed-off-by: Zhaoyang Huang <[email protected]> > > --- > > v2: add gfs2_glock_cachep for same operation > > --- > Hi, > > Thanks. Your patch is now pushed to the linux-gfs2/for-next branch. > I cleaned up the description a bit. For example, I changed "fs:" to > "gfs2:" to conform to other gfs2 patches.
so the patch description now reads: "As gfs2_quotad_cachep and gfs2_glock_cachep have registered shrinkers, amending SLAB_RECLAIM_ACCOUNT when creating them, which improves slab accounting." I'm not sure what that description is based on; the definition of SLAB_RECLAIM_ACCOUNT in include/linux/slab.h looks as follows, which indicates that the purpose isn't really accounting but object grouping: /* The following flags affect the page allocator grouping pages by mobility */ /* Objects are reclaimable */ #define SLAB_RECLAIM_ACCOUNT ((slab_flags_t __force)0x00020000U) #define SLAB_TEMPORARY SLAB_RECLAIM_ACCOUNT /* Objects are short-lived */ Furthermore, would it make sense to use SLAB_RECLAIM_ACCOUNT or SLAB_TEMPORARY for gfs2_bufdata and gfs2_trans as well? Thanks, Andreas
