On Thu, Feb 17, 2022 at 3:03 PM Alexander Aring <aahri...@redhat.com> wrote: > On Wed, Feb 16, 2022 at 7:41 PM Andreas Gruenbacher <agrue...@redhat.com> > wrote: > > > > There's also an unnecessary INIT_LIST_HEAD() in send_op(). > > > > please send a patch in a form which makes it easy to apply. Also > please explain exactly why an "INIT_LIST_HEAD()" is not needed here > rather than just stating that the init isn't needed.
The reason why the INIT_LIST_HEAD is unnecessary is because it initializes op->list, and two lines further down, the list_add_tail overrides op->list. Do with this report whatever you want, but don't expect me to spend extra time on it. Andreas
