On Wed, 2007-11-07 at 18:18 +0100, Gwenole Beauchesne wrote: > On Wed, 7 Nov 2007, Emmanuele Bassi wrote: > > >> Should the third param be '_const_ ClutterColor *color'? It's defined > >> as const in clutter_label_set_color(), so I would expect it to be the > >> same in the constructor. > > > > yes, it should be a const, at least for consistency. > > Oh oh, I was exactly thinking about it yesterday though I have not > submitted a patch yet because there are some other locations where > constification is desirable. Well, only pango layout stuff but are they > meant to be public API?
Watch out, though. const doesn't work well in C, because C has no "mutable" keyword, and no const/non-const method-overloading for getters. It's only useful for simple structs such as ClutterColor. > > Jonathon, can you please open a bug on clutter's bugzilla product at: > > http://bugzilla.openedhand.org/enter_bug.cgi?product=Clutter > > BTW, the new Bugzilla look is nicer. ;-) -- [EMAIL PROTECTED] www.murrayc.com www.openismus.com -- To unsubscribe send a mail to [EMAIL PROTECTED]
