Using a callback I now feed the error information back. Here's the latest change: https://github.com/ulrichard/CMake/commit/adf1cf5184d5a13702a03a090c501f1a6d0e39f4
The following line is still commented out: this->Makefile->StoreMatches(re); Is it important enough to add another callback? What are those matches used for? Rgds Richard Am Freitag, den 29.05.2015, 14:44 -0400 schrieb Brad King: > On 05/27/2015 05:49 PM, Richard Ulrich wrote: > > So with this patch, I can define regex replace rules to group the > > external libraries together. > > Nice. Thanks for working on this. > > > since cmake has to compile with older compilers > > Yes. > > > I extracted the RegexReplace functionality > > from the string processor, and put it in a new file. For the moment I > > commented out the error reporting. I'm not sure how that would be > > handled best. That's where I could use some input. > > The string() command implementation can be refactored out into > an internal helper as you propose. That internal helper will > need to define an abstraction for the error cases so that the > cmGraphVizWriter can capture the errors too. Then the string() > implementation can capture them and transform them back into > the original error messages. > > Thanks, > -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
