As requested, I put the patch right into the VS10 target generator. Please note 
that this requires a new dependency on <windows.h>, which was _not_ there 
before. I tried to stick to the existing style. Please let me know if I need to 
use different APIs or anything else needs to be improved.

Thanks,
Mike

-----Ursprüngliche Nachricht-----
Von: cmake-developers [mailto:[email protected]] Im Auftrag 
von Brad King
Gesendet: Freitag, 25. September 2015 14:34
An: [email protected]
Betreff: Re: [cmake-developers] Timestamp of VS-generator rule files

On 09/25/2015 07:45 AM, [email protected] wrote:
> I wrote a small function OutdateFileTime(const std::string& filename)
> which does what it sounds like. It is called by the VS generator right
> after rule file creation with Touch. I wasn't sure whether this function,
> which uses Win32 API should go into the generator code or SystemTools.

Until the functionality is needed elsewhere I see no reason not to just
put it right in the generator implementation.  If a more general purpose
for it is found later it can be refactored over to SystemTools and made
to work on more platforms.  No need for that yet though.

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Attachment: vs-old-rule-files.patch
Description: vs-old-rule-files.patch

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to