On 08/18/2016 01:47 PM, Titov Denis wrote:
> + } else if (*i == "RETRY_COUNT") {
> + ++i;
> + if (i != args.end()) {
> + retryMaxCount = atoi(i->c_str());
> + } else {
> + this->SetError("DOWNLOAD missing count for RETRY_COUNT");
Adding tests for these options will be difficult, but we can at least
add tests for the error cases. Please look at adding cases to
Tests/RunCMake/file/RunCMakeTest.cmake
for these. See Tests/RunCMake/README.rst for documentation of how
this test infrastructure works.
Sorry I didn't notice this during my first review.
Thanks,
-Brad
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers
