On 08/07/2010 05:25 PM, Alexander Neundorf wrote:
> diff --git a/Modules/FindSubversion.cmake b/Modules/FindSubversion.cmake
> index 58a179d..30220d1 100644
> --- a/Modules/FindSubversion.cmake
> +++ b/Modules/FindSubversion.cmake
> @@ -2,7 +2,12 @@
> # The module defines the following variables:
> # Subversion_SVN_EXECUTABLE - path to svn command line client
> # Subversion_VERSION_SVN - version of svn command line client
> -# Subversion_FOUND - true if the command line client was found
> +# SUBVERSION_FOUND - true if the command line client was found
> +# Subversion_FOUND - same as SUBVERSION_FOUND, kept around for compatibility
IMO the preferred capitalization is "Subversion_FOUND".
All the other variables use that. IIRC your standard
macro set the value with upper-case because that was
what many packages did at the time. I think we should
start setting both in the macro and then document the
natural case instead.
If I write
find_package(Subversion)
I would expect to write
if(Subversion_FOUND)
... ${Subversion_SVN_EXECUTABLE} ...
endif()
and not the inconsistent
if(SUBVERSION_FOUND)
... ${Subversion_SVN_EXECUTABLE} ...
endif()
Thoughts?
-Brad
_______________________________________________
cmake-developers mailing list
cmake-developers@cmake.org
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
