On 05/25/2011 02:59 PM, Will Dicharry wrote: > I fixed your issues and added a couple more fixes for problems with the > module. They have been merged with stage/next.
Thanks. Those look pretty good. However, this looks strange: +if( HDF5_FOUND ) + mark_as_advanced( + HDF5_INCLUDE_DIRS The mark_as_advanced command should only be given the names of cached values. All the plural names can be dropped. The names of values used for find_*() commands in the autoconf-built section should be added. Also, the advanced status should not depend on whether HDF5 is found. Perhaps those marks can move into the section that creates the cache entries. Thanks, -Brad _______________________________________________ cmake-developers mailing list [email protected] http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
