On 07/18/2011 03:43 PM, Alexander Neundorf wrote: > Done. There is now an enum which can have the values SCRIPT_MODE, > FIND_PACKAGE_MODE and NORMAL_MODE.
Good. > So, CMAKE_SIZEOF_VOID_P can be given to the script from the outside via -D. Good. This should be encouraged. Is it feasible to require it? Does cmake.m4 always know? > If this is not done, it checks for /usr/lib64. If found -> 64bit. > If it doesn't exist, it then does /usr/bin/file /usr/bin/file, and checks > whether the output contains "64-bit". If so -> 64bit. I'm not sure these are good heuristics but I can't think of anything easy off the top of my head. > For the multiarch stuff: the script now uses the regexp as defined in > Linux.cmake to check whether such a directory exists, and if so, uses the > first one found. > If there are multiple matching directories, this value again has to be given > from the outside. Sounds good. > I think both issues above should work for all one-architecture installations. Fair enough. > Another question: the cmake.m4 is based on the m4-file for pkgconfig, which > has the GPL header at the top. So, the cmake.m4 still has that header at the > top. > Is this a problem ? Yes. We at least need to distribute the GPL "COPYING" file with it. In the source tree the two files would need to appear together in a directory separate from any other files. > I don't know how the license of a file, which is installed by cmake, but not > compiled-in nor used by cmake itself influences cmake. CMake doesn't even invoke the code in that file so the license does not propagate. However I'm hesitant to distribute anything with CMake that is not compatible with our main license. It will be a PITA to document the licensing situation properly. -Brad _______________________________________________ cmake-developers mailing list cmake-developers@cmake.org http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
