On Tue, Sep 27, 2011 at 08:19:39AM -0400, Brad King wrote: > On 9/26/2011 11:48 PM, Peter Collingbourne wrote: >> Now that the Ninja generator is passing all tests on Linux, I have >> decided to start preparing patches, and I am starting with some >> refactorings and bug fixes developed in the course of developing the >> Ninja generator. Three of the patches were originally by Nicolas >> Despres, the rest are by myself. > > Fantastic! Thanks for the well-formatted patch submission. It was easy > to review the inline patch series. I also fetched your prep branch from > github. I think we can merge it as soon as the 2.8.6 release is finalized.
Great. I will plan to submit the main Ninja generator patch on top of the branch after it is merged. > Patches 1-6 look good. Please expand the commit message in patch 7 to > elaborate on the specific problems it fixes. That looks like a real bug > fix rather than just refactoring. I guess no one has been using per-config > link flags. I have modified the commit message to include more details, and pushed a modified branch to github. Per-config link flags should certainly work for most generators; the test suite includes a test for them (which is how I found this bug). It looks like the only other generators to use the ComputeLinkFlags function are the Visual Studio 6 and 7 generators (via cmTarget::CreateCustomTargetsAndCommands), which use it to build custom link commands for languages not falling within a set of predefined languages, including C and C++. That might explain why the issue with this function had not been noticed before. Thanks, -- Peter -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
