Am Donnerstag 12 Januar 2012, 16:58:05 schrieben Sie: > On 1/12/2012 3:42 PM, Rolf Eike Beer wrote: > > I just pushed the topic "openssl-version" to stage and would like > > someone to review it. There are 2 patches in it. The first one is an > > obvious bugfix and makes the version number detection work at all with > > OpenSSL 1.0.0! Currently the version number shown is "1..", which is > > fixed by the first patch. > > > > The second one adds an additional variable, OPENSSL_VERSION_STRING, like > > other modules also have. This variable holds the complete version > > number, e.g. "1.0.0f". > > The opensslv.h in 1.0.0 documents the version number encoding, and > it looks like it changed a bit through some versions. Please add > comments near the parsing code that explain how it handles this.
Done. > Also, the examples given in the header are confusing because they > leave out the patch level from the string. I think the patch level > can be included as a fourth component in our OPENSSL_VERSION var. Or just put the normal OpenSSL version string in there? It works for VERSION_LESS and friends. And since FIND_PACKAGE() handles version selection anyway I don't see what a user should have to do with it anyway. I've pushed 2 more changes to that branch. The first one add documentation, the second one parses the version number only once and puts the result in a list and uses that elements later on. And it get's rid of some really long lines. Eike
signature.asc
Description: This is a digitally signed message part.
-- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
