Eric Noulard wrote:
> 2012/1/31 Eric Noulard <eric.noul...@gmail.com>:
> > 2012/1/31 Rolf Eike Beer <e...@sf-mail.de>:
> >>> Ok Agreed.
> >>> Just merged the branch to next.
> >> 
> >> Just spotted a bug in it:
> >> 
> >> @@ -559,6 +511,8 @@ bool cmDocumentation::CreateSingleModule(const char*
> >> fname,
> >>     {
> >>     if(line.size() && line[0] == '#')
> >>       {
> >> +      /* line beginnings with ## are mark-up ignore them */
> >> +      if (line[1] == '#') continue;
> >>       // blank line
> >>       if(line.size() <= 2)
> >> 
> >> Just assume line is "#", then you will access beyond end of line.
> > 
> > Nice catch I'll fix it later tonight.
> 
> Should be fixed and pushed.
> 
> Merge topic 'ImproveCPackDoc-reloaded' into next
> 
> cc4ac32 Calm down compiler warning about unused var
> 1b31c19 Fix potential bad memory access, thanks to Rolf
                                                     ^^^^

You should go and fix this or I will be angry with you for ages. ;)

Eike
-- 

Attachment: signature.asc
Description: This is a digitally signed message part.

--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Reply via email to