2012/2/19 Peter Collingbourne <[email protected]> > On Fri, Feb 17, 2012 at 09:16:31PM +0100, Nicolas Desprès wrote: > > 2012/2/17 Bill Hoffman <[email protected]> > > > > > On 2/17/2012 12:26 PM, Nicolas Desprès wrote: > > > > > >> > > >> I think it is a bug in the generator which do not escape the space > > >> properly using the $ character as supported by Ninja. > > >> > > >> -- > > >> Nicolas Desprès > > >> > > >> Will you be able to fix that? > > > > > > > I think yes. It is just a matter of time. My weekend is already > overloaded. > > I'll try to do it. If Peter or someone else in the community comes up > with > > a patch before me everybody would be happy :-) > > I decided to look into escaping rules this weekend. Now with the > code on the ninja-generator branch, CMake can build itself with both > source and build directories containing spaces, and pass all tests. > LLVM/Clang can also build with both directory names containing spaces. > > Thanks for this Peter. I have just tried the new stage/ninja-generator branch with spaces in both the source and the binary directory and I got this result for the test suite:
The following tests FAILED: 83 - CPackComponents (Failed) 217 - CMake.CheckSourceTree (Failed) Note that on my Linux box: - CMake.CheckSourceTree always fail even on the master branch (I never tried to understand why). - CPackComponents fails only when there are spaces but the Unix Makefiles generator has the same issue. Cheers, -- Nicolas Desprès
-- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
