On 2/25/2012 5:39 AM, Alexander Neundorf wrote:
I updated the FindPackage_ModeWarning branch.
It should now have everything as discussed here, please review.

Nice.

The MODULE keyword warning suggests using NO_MODULE which does not
make sense (but it does for CONFIG of course).  Perhaps for MODULE
it can just warn about the min required version.

I'll perform a more detailed review after that is fixed.

The FindPackageTest now also tries to list more or less all possible failure
messages, the output is attached.

Thanks, that is good for manual reference.  Eventually I'd like
to see a real test that verifies the output for each case.  I
think the Tests/CMakeOnly directory is a good place along with
the PASS/FAIL_REGULAR_EXPRESSION test properties.  We can look
at adding such tests separately after the main topic is done.

Thanks,
-Brad
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Reply via email to