Alex, Brad and I reviewed the MakingConfigFilesEasier_ConfigureMacro topic, but have two small additional changes to request before we merge it to master.
(1) There's a generated comment referencing "ConfigureConfigFile.cmake" but there is no such file. Please change that to CMakePackageConfigHelpers.cmake. And (2) you are using the "PACKAGE_HELPER_" prefix... I thought the prefix was intended simply to be "PACKAGE_". After you fix up those two minor points, we'll merge it to 'master' next time. Thanks, David On Tue, Feb 21, 2012 at 3:59 PM, Brad King <[email protected]> wrote: > On 2/21/2012 3:17 PM, Alexander Neundorf wrote: >> >> On Friday 17 February 2012, Alexander Neundorf wrote: >>> >>> So, I'm not that sure that using "PACKAGE" instead of "CONFIG" is really >>> better (the branch I pushed uses "PACKAGE", but I could change this >>> again). >> >> >> Ok, so we stay here with "PACKAGE", also in the light of the new "CONFIG" >> keyword for find_package() ? > > > Yes. > > The information contained in the generated variable values is about > the target package, not about the configuration file storing the info. > > Thanks, > -Brad > > -- > > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Please keep messages on-topic and check the CMake FAQ at: > http://www.cmake.org/Wiki/CMake_FAQ > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
