David Cole wrote: > Eike, > > I've got a test machine setup where I'm using the latest Xcode 4.3 > from Apple, and I'm getting output like this from the AllFindModules > test: > > CMake Error at CMakeLists.txt:52 (message): > GIT_VERSION_STRING has unexpected content 1.7.7.5 (Apple Git-26) > > Is there a way to say "it's ok for the version string to have extra > stuff after the version number".... without breaking your concept of > "expected content" too much? Really, our expectation of a version > number string in CMake is anything that's useful with VERSION_LESS and > VERSION_GREATER comparisons. The above string is useful, and would be > valid for version comparisons. > > Perhaps we could use the regex you're using now, but only care about > the *start* of the string?
I have no problem if you change the ending to "( .*)?" (or whatever is correct). It now has been proven that the expectation of what would come out of this is too narrow. On the other hand I wonder if we should simply cut away that trailing stuff in FindGit.cmake. Eike --
signature.asc
Description: This is a digitally signed message part.
-- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
