> >>>> It would be very simple to add a "clean" target that simply executes > >>>> "ninja -t clean" as a custom command, if the ninja generator guys > >>>> think that's a reasonable idea to keep things similar to the > Makefiles > >>>> generator. > >>> > >>> Sounds reasonnable. > >>> > >> > >> I have just pushed on my GitHub CMake fork a branch called > >> 'ninja_convenience_targets' that implement that: > >> https://github.com/polrop/CMake/commits/ninja_convenience_targets > >> > > > > I know this branch does not solved all the issues mentioned in this > > thread but it is a good start. Could somebody have a look at them > > David please? > > > > @alex This is not Ninja philosophy to add such target name so I have > > added them only because you ask for them for Eclipse. I hope they will > > help you. For your information, I have tried (without any hope) to add > > them to Ninja it self (https://github.com/martine/ninja/pull/275 and > > https://github.com/martine/ninja/pull/276) but they have been > > rejected. > > > > Thanks, > > > > -- > > Nicolas Desprès > > > Implementing these as custom targets in the Ninja generator in CMake > is definitely the right way to go. Ninja does not need knowledge of > these targets whatsoever. (Make has none, we just generate these > convenience targets for CMake projects that use the Unix Makefiles > generator...) > > The point of this whole thread is that the Ninja generator falls short > of the Unix Makefiles generator in terms of its support of these > custom targets. > > The changes to CMake look good to me (just inspecting the code, didn't > try it). Can somebody take Nicolas's patches and get them merged to > 'next' in CMake?
OK, merged it via 'ninja_convenience_targets' into next: http://cmake.org/gitweb?p=stage/cmake.git;a=log;h=refs/heads/next > > > Thx, > David -- NEU: FreePhone 3-fach-Flat mit kostenlosem Smartphone! Jetzt informieren: http://mobile.1und1.de/?ac=OM.PW.PW003K20328T7073a -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
