On Friday, June 15, 2012 09:56:51 PM Alexander Neundorf wrote: > Hi, > > attached is a small patch which sets the OBJECT_DEPENDS property of a moced > file to the generated moc file. > This has the effect that before the cpp file is built, moc has been run on > it. We have that in KDE's version of qt4_generate_moc() this way since 2006 > and it works for us. > In cmake's version, it was removed January 11th 2008, the removed call to > MACRO_ADD_FILE_DEPENDENCIES(): > http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=510f578f8b53858fbb541c4e7 > e4731de9bfbd483 > > Now since we are trying to get rid of our custom stuff in KDE, we hit that > issue when trying to build parts of KDE with FindQt4.cmake from cmake. > > Do you remember why this line was removed ? > What do you think about adding it again, as the attached patch does ? > > Alex
It was probably removed because I thought add_custom_command() already added the needed dependency information. It should already have this: mocable.h -> moc_mocable.cpp -> moc_mocable.o or mocable.h -> mocable.moc -> mocable.cpp (includes mocable.moc) Why do we need the extra dependency like this? mocable.h -> mocable.cpp -- Clinton Stimpson Elemental Technologies, Inc Computational Simulation Software, LLC www.csimsoft.com -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
