Patrick Gansterer wrote:
> Hi,
> 
> On Sat, 14 Jul 2012 21:08:24 +0200, Rolf Eike Beer wrote:
> > -in Modules/Platform/Windows-cl.cmake you initialize some variables
> > in both
> > branches of an if(). You should keep the order you set them the same
> > in both
> > branches as is makes comparing this much easier.
> 
> Where exactly? I don't find it. :-/

Directly before that:

> > -you don't set CMAKE_DEBUG_PLATFORM_DEFINES for WinCE. I don't know
> > if that is
> > a bug or intentional. If it is a bug then set it, otherwise I would
> > add a
> > comment why this isn't needed.
> 
> The WinCE compier has no support for /RTC1.

But you don't add any of the other things you set for release configuration 
either, that's what wonders me.

Eike
-- 

Attachment: signature.asc
Description: This is a digitally signed message part.

--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Reply via email to