On 08/10/2012 10:30 AM, Stephen Kelly wrote:
> I've updated the branch with the API change to use std::set. The XCode
> generator does not use the cmLocalGenerator::AppendDefines method, but the
> VisualStudio6Generator does.
That wasn't quite what I had in mind. The string of escaped
defines for the command line should be paired with a set of
raw defines. Before appending definition to the end of the
string test set insertion:
if(defined.insert(def).second)
{
// first time we see this one
...rest of logic to append to "defines" string.
}
That way no behavior changes unless there is a duplicate.
IMO it is also cleaner to store the unescaped original
definitions in the std::set.
-Brad
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
