Stephen Kelly wrote: > Hi, > > I was looking at 4be6783711b2ff510c3449c5de22d35663d8bfc1 and > 3553001bcc425dfb5d84a2dc8d657fe92c007962 with a view to forward porting them > to Qt 5, but I think they are still buggy. > > As xml is not line-based, the parsing should be able to handle legal content > like this: > > <file > alias="foo">images/star.png</file> > > The current code does not handle the above, but after reverting the patch > (ie, to it's CMake 2.8.9 form), it is handled correctly.
Because it concatenates everything and does the regex matching then. So, yes, both should be dropped. But, hm, no, that's the wrong way. Stephen, I don't believe a single word you are writing. If you could come up with a unit test that you can commit then maybe I could be convinced to trust you and let you revert all that stuff ;) Eike --
signature.asc
Description: This is a digitally signed message part.
-- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
