On Tue, Nov 6, 2012 at 2:31 PM, Brad King <brad.k...@kitware.com> wrote:
> On 11/06/2012 08:22 AM, Petr Kmoch wrote: > > I verified that the tests fail when CMAKE_MAKE_PROGRAM points to msbuild, > > because 'cmake --build' does not operate on the .sln in such case. > > FYI, a recent issue was filed that may require cmake --build to read > the .sln file: > > http://www.cmake.org/Bug/view.php?id=13623 > > It has some overlap with your work in case you want to try fixing it. > > > This means it makes no sense to run the tests when using msbuild. > > Shall I send you a patch to disable the tests for it? > > And if so, on what commit should I base it? > > Please rebase all your commits on master and squash the not-on-msbuild > part into the same commit that adds the test. Include a comment > explaining why it can't run with MSBuild. > Yup, I'll do that. Petr
-- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
