On Mon, Dec 3, 2012 at 7:00 AM, Brad King <[email protected]> wrote: > On 11/30/2012 04:54 PM, Amit Kulkarni wrote: >>> Thanks. Please format this as a patch series that makes changes >>> in logical groups (possibly only one file each) and explains their >>> purpose in the commit messages. >> >> a email sent to cmake-developers@ for each file touched with a commit >> message? > > No, just please group the related changes that have a common explanation. > If two changes have different reasons then they belong as separate commits. > Then you can attach the entire patch series to one message if you want.
I sent the patches as separate messages to prevent any confusion. >> A /usr/local/lib/qt3/bin/moc exists on my machine. I think that the >> OpenBSD environment (linker or libtool) takes care of it. David will >> confirm here. I notice all the FindQt3 patches are /usr/local. > > This is an example of why we need commit messages to explain the changes. > From reading the patch I have no idea why the path makes sense there. OpenBSD allows installs of qt3 and qt4 with a goal of concurrently supporting the package builds of kde3 and kde4. So qt3/qt4 are installed in appropriate folders under /usr/local. The package infrastructure takes care of installing files either under lib/qt3 or lib/qt4 (just giving an example of lib, a similar thing happens for include, share/doc etc.) relative to a /usr/local. Some programs common to both are renamed with either a suffix of 3 or 4 to prevent confusion when invoking them. I hope this explanation is sufficient for the Qt related patches? I will wait for your okay before sending out the Qt related patches tomorrow. The current patches were extracted from http://www.openbsd.org/cgi-bin/cvsweb/ports/devel/cmake/patches/ by David. He refactored stuff which can be pushed upstream to cmake. >> I am unfamiliar with PATH_SUFFIXES (and with CMake in general). I >> looked at FindBoost.cmake and FindGTK.cmake but they were all using >> PATH_SUFFIXES inside of find_path() whereas in the diff above it is >> inside a set(TCLTK_POSSIBLE_INCLUDE_PATHS). I am not sure how to >> proceed here. > > The variable is used to consolidate options to later find_path calls. > The PATH_SUFFIXES option is documented in the command: > > http://www.cmake.org/cmake/help/v2.8.10/cmake.html#command:find_path > > Anyway, I think you can go with the change you already have and > someone else can refactor the paths later. This suggestion was about > a general improvement rather than just an OpenBSD port. I think someone else who is more experienced can refactor for Tcl/Tk later! I just submitted the Tcl/Tk 8.4/8.5 version strings. Thanks -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
