Stephen Kelly wrote: > > Hi there, > > I've just pushed tid-system-argument to my clone. It doesn't include unit > tests yet, but I wonder if I can get it into 2.8.11? >
I looked into this a bit. The way SYSTEM include directories are marked is makefile-local, not target-local. That means that code like this would be confusing: add_library(foo ...) add_library(bar ...) target_include_directories(foo SYSTEM PRIVATE /sys/inc) # Warning: /sys/inc marked as a system include if used by # bar too. On the other hand, include_directories(SYSTEM /sys/inc) adds /sys/inc as an include dir to all targets in the makefile, which might not be wanted. I think the best solution would be to refactor the way system includes are handled to be target-local instead of makefile-local and then add the patch. All that can be done in a future release. Thanks, Steve. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
