Brad King wrote: > On 03/11/2013 07:01 PM, Stephen Kelly wrote: >> Stephen Kelly wrote: >>> Alexander Neundorf wrote: >>>> The patch only avoided that specific situation when it occured with >>>> automoc, but the same situation can also happen independent from >>>> automoc. >>> >>> Not really, the attached case can only crash because of the automoc >>> support built-in in cmake. Can you create a testcase which does not rely >>> on that feature? >> >> Oh, of course the obvious way is to simply comment out the automoc lines. >> That causes the same crash. > > Fixed: > > http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=92a2ab70 > http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ab079ee6 > > but please review these changes.
They seem fine to me. It may be possible to return earlier (eg in GetIncludeDirectories/GetCompileDefinitions) to avoid executing the generator expressions at all. It would still be an error case though. That can be done at some point in the future. Thanks, Steve. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
