On 2013-05-21 15:54, Brad King wrote:
On 05/08/2013 05:09 PM, Matthew Woehlke wrote:
After chatting with Marcus how to resolve ParaView link errors due to
things using Google Protobuf needing to link to pthread, I have updated
FindProtobuf.cmake to also find the pthread library on UNIX platforms
and include it in PROTOBUF_LIBRARIES.
This should fix link errors in a number of projects and/or remove the
need for downstream users to add pthread themselves when using protobuf.
The branch (name in summary) is on stage. Please have a look if this is
reasonable and can be merged to master once 2.8.11 is out.
The change looks okay to me. Please revise the commit message
to start in "FindProtobuf:" and update the text accordingly.
Done.
Then merge to 'next' for testing.
How do I do that? Based on the wiki, I unsuccessfully tried:
$ ssh g...@cmake.org stage cmake merge -b next fix-protobuf-threads
not allowed: stage cmake merge -b next fix-protobuf-threads
--
Matthew
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
