Sean McBride wrote: > Hi all, > > Recently in clang trunk, they added a new warning which we now see on Rogue7 > since I updated my clang: > > <http://open.cdash.org/viewBuildError.php?type=1&buildid=2949429> > > CMake/Source/kwsys/RegularExpression.cxx:347:5: warning: 'register' storage > class specifier is deprecated [-Wdeprecated-register] register const char* > scan; > ^~~~~~~~~ > > I can make a patch to remove the 'register' keyword, if you will accept it. > Anyone have a philosophical objection? If so, I will suppress the warning.
That code dates back until 1989/1991 according to the comments. At that time it may have been a good idea to hint the compiler which variables to put into registers, but I don't think that this would give much gain today. I remember having seen something like a year back where the register statement gave better code, but these thing should be very rare and compilers usually tend to improve. So, IMHO: rip it off. Eike --
signature.asc
Description: This is a digitally signed message part.
-- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
