Steve,

I merged this topic, consisting of commits a18e9586..d7dd0108,
to master this morning.  However, when I use the VS generators
on Windows CMake now crashes because something clobbers the
cmMakefile::SourceGroups member.  This didn't crash when the
topic was in next.  Does it depend on something else?

I bisected the problem down to commit d7dd0108.

While investigating I noticed something I missed while reviewing
the topic earlier.  The cmMakefile::GetProperty implementation
tries to re-compose the property value as a ;-list, but does not
preserve escaped semicolons which IIRC are supported when setting
the COMPILE_DEFINITIONS property.  Please add a test case that
checks getting the property with ;s.

Thanks,
-Brad
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Reply via email to