Hi, 

Commit 342fc0401005 (Recognize shared library files with a numerical suffix, 
2013-04-11) resulted from 

 
http://thread.gmane.org/gmane.comp.programming.tools.cmake.devel/6613/focus=6616

In a more-recent review, I thought that if there is an extension in the exts 
list which already has a numerical extension, then the extra check for a 
numerical extension shouldn't be added for that entry. 

  else if(type == LinkShared)
    {
    libext += "(\\.[0-9]+)?";
    }

The code is quite complex with regexes. I wonder if something like that can 
be fixed, or should it just be left as-is?

Thanks,

Steve.


--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Reply via email to