On 07/31/2013 11:05 AM, Stephen Kelly wrote:
> Config sensitive dirs are likely more common for libraries 
> than includes, so actually I think it would be fine to make that an error 
> and always do full evaluation.

To clarify, the no-config rule is for INCLUDES DESTINATION only, but full
with-config evaluation will be allowed for a real DESTINATION.  The
config can be honored for file destinations.  For targets we generate
a per-config IMPORTED_LOCATION_<CONFIG> anyway.  We will wait for after
2.8.12 for the file destination generator expressions.

> I've pushed INCLUDES-DESTINATION-no-config to my clone with an 
> implementation. Can I merge it to next?

Yes, but one comment first:

+  if (cge->GetHadContextSensitiveCondition())
+    {
+    cmMakefile* mf = target->GetMakefile();
+    cmOStringStream e;
+    e << "Target \"" << target->GetName() << "\" is installed with "
+    "INCLUDES DESTINATION set to a configuration sensitive path.  This is "

Does "context sensitive" condition ever mean something other than
"configuration sensitive"?  If so then users may produce a case that
triggers this error in a confusing manner.

-Brad
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Reply via email to