On 08/01/2013 04:47 PM, Rolf Eike Beer wrote:
> Alexander Neundorf wrote:
>> I'm not sure I would have made this a find-module, instead of a simple
>> module which can be included and then provides a function, but I think this
>> doesn't matter much.
>
> Because I get things like components for free then ;)

Since it looks like a find module it is running as part of
the all-find-modules tests:

 Tests/FindModulesExecuteAll/CMakeLists.txt
 Tests/CMakeOnly/AllFindModules/CMakeLists.txt

Since this module is not really a find module and already
has its own dedicated Module.CXXFeatures test, please teach
the above two tests to skip it.

---------------------------------------------------------------------

All three above tests are timing out on the Watcom build:

 http://open.cdash.org/viewTest.php?onlyfailed&buildid=2992340

Watcom interactively prompts in some error cases so it times
out the automated tests.  I've finally just taken the time to
figure out how to suppress the prompt which I'll add in another
topic.  Anyway, the error occurs in one of the try_compile checks:

 [100%] Building CXX object 
CMakeFiles/cmTryCompileExec1059188181.dir/src.cxx.obj
 Error! E059: unable to open 'd=c++11'

The corresponding flags.make has:

 CXX_FLAGS =  -w=3 -xs -D_HAS_CXX11_FLAG -br -bm -d2   -std=c++11

The wcl386 compiler help shows

 -st touch stack through SS first

You may need to hard-code answers for some compilers.

---------------------------------------------------------------------

What is the expected behavior if one writes

 find_package(CXXFeatures QUIET)

?  If this is supposed to be a find module then it should not
have guaranteed failure cases like this:

 if (NOT CMAKE_CXX_COMPILER_LOADED)
     message(FATAL_ERROR "CXXFeatures modules only works if language CXX is 
enabled")
 endif ()

It should respond with NOTFOUND for everything if CXX is not
enabled IMO.

Thanks,
-Brad
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Reply via email to