Daniele E. Domenichelli wrote:
> On 12/08/13 15:36, Stephen Kelly wrote:
>>> The difference is that if GTK2_USE_IMPORTED_TARGETS the
>>> GTK_${_var}_LIBRARY will link the target (and it's dependencies)
>>> otherwise it will link only the library (without dependencies) using the
>>> DEBUG or RELEASE version, depending on what was found.
>>
>> Are there also GTK_${_var}_LIBRARIES variables?
>>
>> Conventionally, the *LIBRARIES variables are for user-use and the
>> *LIBRARY variables are not...
>
> Not at the moment, but perhaps it might be useful to add them... What do
> you think?
My personal view is that you should recommend people to use the target names
directly and not the variables :), but I know that view is not universally
shared.
> I tried locally but I get merge conflicts, so I'm not sure if I'm doing
> it right... If it is not an issue, I'd just leave the extra commit.
Brad can squash up your branch before merging to master if he wants to.
>>>> * If GObject depends on glib, then the line
>>>> _GTK2_ADD_TARGET_DEPENDS(ATK gobject glib) does not need to specify
>>>> glib. I would minimise those dependency listings.
>>>
>>> atk explicitly requires glib (glib.h is included in some headers)
>>> therefore I thought it was better to make this explicit here as well.
>>
>> *shrug*. I've seen the same argument presented before, but I don't agree
>> with it. As you wish.
>
> I'm not expert, I'm just saying what I thought when I wrote it, so if
> you think it is better in the other way I can change it.
I think that's your call as the maintainer or Brads call.
>>>> * fontconfig seems to be only a compile dependency but not a link
>>>> dependency.
>>>>
>>>> * freetype seems to be a link dependency (I assume, as it is added to
>>>> GTK2_LIBRARIES), but the library does not seem to be in the link
>>>> interface of the Cairo library. ${FREETYPE_LIBRARIES} can just be added
>>>> to the INTERFACE_LINK_LIBRARIES, but I think it might make sense to
>>>> create an imported target for it too anyway (in FindFreetype.cmake)?
>>>
>>> To be honest I'm not completely sure here... On windows (with the GtkMM
>>> installer) I'm having some issues with freetype, when linking
>>> ${GTK2_LIBRARIES}, but it links when I use the libraries one by one.
>>
>> It would be interesting to get more information on this.
>
> I did a few more tests, and it looks like that, at least on my system
> and on windows, FREETYPE_LIBRARIES are not required, they are linked to
> some other libraries (i.e. cairo) but they don't need to be linked
> explicitly
> On the other hand, the FREETYPE_INCLUDE_DIR is required, because some
> public header includes freetype headers.
Can you confirm that the things used in those cases from the headers are
only defines, enum values, inline functions etc, and not anything that
becomes part of the ABI (such as inheriting from a type etc)? Or, otherwise,
can you determine why the freetype header is in the public headers?
>
> On window using gtkmm installer, find_package(Freetype) freetype is not
> found, FREETYPE_FOUND is FALSE, FREETYPE_LIBRARY is
> FREETYPE_LIBRARY-NOTFOUND, but FREETYPE_INCLUDE_DIR is set correctly
> (the headers are installed, but the .lib file is missing)
> I'm not sure if this is a bug in FindFreetype (FREETYPE_INCLUDE_DIR
> should be unset if freetype was not found?)
Perhaps. If so, maybe that's something FPHSA should do? Seems like a
separate topic though.
Do you mean that the windows gtk installer does not install the .lib file at
all, but does install the include files (because it only uses defines/enums
and doesn't need to link to the thing?)?
> On the other hand, fixing this means that building gtk programs will
> fail. Perhaps FindGTK2 should NOT use FindFreetype and should look for
> the headers only internally (like for fontconfig)
It seems so, yes.
Btw, was there any effort to get the gtk upstream to produce cmake config
files with IMPORTED targets?
Thanks,
Steve.
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
