Hello Brad,
On 12/11/13 19:14, Brad King wrote:
> This hunk is important:
>
> + // SET (VAR PARENT_SCOPE) // Removes the definition of VAR
> + // in the parent scope.
> + else if (args.size() == 2 && args[args.size()-1] == "PARENT_SCOPE")
> + {
> + this->Makefile->RaiseScope(variable, 0);
> + return true;
> + }
>
> and should be taken regardless of the decision below.
[...]
> Therefore I think we can actually skip the policy in this case and
> simply treat this as a bug fix, especially given that the change will
> come with a major version number.
I updated the branch following your comments. Does it look good now?
Cheers,
Daniele
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers