On 11/15/2013 11:39 AM, Brad King wrote:
It looks like you added the reserved check to cmGeneratorExpression
in the IsValidTargetName method. This method is used in other
places to validate generator expression syntax, and in those places
the reserved target names may be allowed.
Can I keep the extracted method in cmGeneratorExpression or would there
be a more appropriate location for it?
In the list of reserved names you also need to add uppercase
"INSTALL". Otherwise I think you got them all.
I should be able to get that fixed as soon as I get home from work.
Thank you for looking it over!
Nils
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
