On 11/19/2013 12:53 PM, Stephen Kelly wrote:
> I've implemented this and it is superior in several ways - There's less code
> duplication, more cohesion of related code, fewer area to expand when adding
> new features, and a log with all relevant information.
Great!
> As try_compile is much slower, I retained the more simple compile-only
> version for generators which can handle it.
Let's not optimize prematurely. It is much simpler to have a single
approach that works everywhere. The direct-compile approach requires
extra/duplicate infrastructure like _CMAKE_${lang}_CREATE_OBJECT_FILE
to be maintained and it may not exactly match how the project will be
generated (where the try_compile approach does).
-Brad
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
