On 01/06/2014 04:44 PM, Brad King wrote:
Please wait until after Clinton's unicode topics have settled so that you can get more isolated feedback from the dashboard.
Will do.
This hunk looks strange:

+    set(COMPILER "${CMAKE_CXX_COMPILER}${CMAKE_C_COMPILER}")
+    get_filename_component(COMPILER_DIR "${COMPILER}" DIRECTORY)

I don't think both compilers should be used at the same time :)


Yeah, I assumed only one is set at a time but I'll have to check that.
CMakeFindBinUtils is included by CMakeDetermine<LANG>Compiler.cmake.
Perhaps they could pass their language into CMakeFindBinUtils so this and similar constructs that check variables for both languages can be removed.

Thanks!

Nils
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Reply via email to