On 06.01.2014 16:48, Brad King wrote:
The topic adds the variable "CMAKE_DISABLE_INSTALL_RULES".
For skipping certain generation features we already have the
convention "CMAKE_SKIP_..." for variable names.  Perhaps
"CMAKE_SKIP_INSTALL_RULES"?
Done.


Please add a RunCMake.install test with a case covering the warning:

+    mf->IssueMessage(cmake::WARNING,
+      "CMAKE_DISABLE_INSTALL_RULES was enabled even though "
+      "installation rules have been specified");

Also please look at adding a full test that verifies that
no cmake_install.cmake file is generated and if possible that
"cmake --build . --target install" fails.

I've added checks for cmake_install.cmake and the warning in the subtests that I added in the new "RunCMake.install" test. In the new test "MissingInstall" I run the command you suggest and verify it gets a non-success exit status.

Nils
--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Reply via email to