Hi Eike, thanks for reviewing! I've just pushed a new version, which should fix all the issues you mentioned. I'm also setting now Hg_FOUND using FOUND_VAR (this is also recommended in the documentation.)
Anything more left to do? The only thing which bothers me is the _VERSION_STRING in FindHg (which is similar to FindGit) and the same variable being called _VERSION in OpenCL, if there is a policy on that, I would like to use the same variable name in both. Right now I was aiming more for consistency with existing packages. Cheers, Matthäus On 15.02.2014 19:33, Rolf Eike Beer wrote: > Am Samstag, 15. Februar 2014, 18:54:47 schrieb Stephen Kelly: >> Rolf Eike Beer wrote: >>> Matthäus G. Chajdas wrote: >>>> Hi Eike, >>>> >>>> all right, then Hg, as it's FindHg, unless there is a naming policy I'm >>>> not aware of. I was just confused a bit due to FindGit, which uses GIT_ >>>> as the prefix. >>>> >>>> How do I proceed from here? What should I do next? >>> >>> I think you can reduce FindHg quite a bit. Here are some examples: >>> >>> -do not set Hg_FOUND to anything, FPHSA will do it for you >> >> You need to set it explicitly when using FPHSA actually, because it sets >> uppercase(Hg_FOUND) == HG_FOUND instead by default. I consider that a bug, >> but the 'fix decision' was to require explicitly specifying the _FOUND >> variable in order to get a sane value. > > Well, then the fix is simply to pass FOUND_VAR Hg_FOUND to it, no? > > Eike > > > -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
